Make crates buildable with minimal dependency versions #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #364 +/- ##
=======================================
Coverage 74.46% 74.46%
=======================================
Files 50 50
Lines 3798 3798
=======================================
Hits 2828 2828
Misses 970 970
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some dependencies seems outdated, and does not compile with rustc 1.49.0.
This pull request bumps some dependencies in order to all crates compile with minimal dependency versions.
You can generate
Cargo.lockwith minimal dependency versions bycargo +nightly update -Z minimal-versions.(Once
Cargo.lockis generated, build and test can be proceeded by stable rustc.)This PR chose literally minimum compilable deps versions to minimize unexpected side effects, but it results in compiler warnings in some crates (for example,
lazy-static v1.0.2usesstd::sync::ONCE_INITinternally, which is now deprecated).I think some dependencies should be updated to more recent versions, but it is out of scope of this PR.